Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2862: KubeletFineGrainedAuthz Graduate to BETA #49578

Merged
merged 1 commit into from
Mar 29, 2025
Merged

KEP-2862: KubeletFineGrainedAuthz Graduate to BETA #49578

merged 1 commit into from
Mar 29, 2025

Conversation

vinayakankugoyal
Copy link
Contributor

Description

Graduate kep-2862: Fine-grained Kubelet API Authz to BETA.

I looked at the existing docs and they sufficiently cover the details so we don't need to update them. Here is a link to the existing docs just in case. Please feel free to comment on this PR if you think we should update them.

NOTE: the banner showing the feature-gate state now autoupdates based on the config being changed in this PR.

Issue

xref: kubernetes/enhancements#2862

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d2cf488
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/679a7a451d117e0008fb1ba8

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d2cf488
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679a7a45a8399d000865d64a
😎 Deploy Preview https://deploy-preview-49578--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim sftim changed the title KEP-2862: Graduate to BETA. KEP-2862: Graduate to BETA Jan 28, 2025
@vinayakankugoyal vinayakankugoyal mentioned this pull request Jan 28, 2025
Open
12 tasks
@Shubham82
Copy link
Contributor

Hi @vinayakankugoyal could you please change the feature gate file name to KubeletFineGrainedAuthz.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2025
@vinayakankugoyal
Copy link
Contributor Author

Hi @vinayakankugoyal could you please change the feature gate file name to KubeletFineGrainedAuthz.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

were those changes synced to dev-1.33?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2025
@Shubham82
Copy link
Contributor

were those changes synced to dev-1.33?

yes, we sync the dev (dev-1.33) branch with the main branch to keep the dev branch up to date.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: effd503de838789ba7ef747977d306ca6cf12fd3

@vinayakankugoyal
Copy link
Contributor Author

vinayakankugoyal commented Jan 30, 2025 •
edited
Loading

/assing @natalisucks

for approval

@vinayakankugoyal
Copy link
Contributor Author

vinayakankugoyal commented Jan 30, 2025 •
edited
Loading

/assign @natalisucks

1 similar comment
@vinayakankugoyal
Copy link
Contributor Author

/assign @natalisucks

@Shubham82
Copy link
Contributor

Hi @dipesh-rawat
Could you please approve this PR, so that it will be merged?

Thanks!

@vinayakankugoyal
Copy link
Contributor Author

@sftim - could you approve this one? Its been awaiting approval since Jan 30th.

@tengqm tengqm changed the title KEP-2862: Graduate to BETA KEP-2862: KubeletFineGrainedAuthz Graduate to BETA Mar 29, 2025
@tengqm
Copy link
Contributor

tengqm commented Mar 29, 2025

@vinayakankugoyal Please provide a link to the upstream k/k change. We are not supposed to merge doc changes before the feature gate change is accepted in the code base. The docs team doesn't have bandwidth to trace all the KEPs and watch all the k/k changes. So, it is your responsibility to show that the change already happened in code (not just in KEP).

@vinayakankugoyal
Copy link
Contributor Author

Well this is the first time I'm hearing this ask. The k/k change has been merged already.

@vinayakankugoyal
Copy link
Contributor Author

kubernetes/kubernetes#129656

@tengqm
Copy link
Contributor

tengqm commented Mar 29, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit e5bc848 into kubernetes:dev-1.33 Mar 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

Assignees

@natalisucks natalisucks

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinayakankugoyal @Shubham82 @k8s-ci-robot @tengqm @dipesh-rawat @natalisucks